[PATCH] D70373: [NFC] [PowerPC] Add volatile flag to a swap optimization test.

Qiu Chaofan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 17 22:42:58 PST 2019


qiucf created this revision.
qiucf added a reviewer: PowerPC.
qiucf added a project: LLVM.
Herald added subscribers: llvm-commits, shchenz, jsji, nemanjai.

This patch is predecessor of D70223 <https://reviews.llvm.org/D70223>. Since the patch is to optimize vector `load`-`update`-`store` pattern, some of the tests might be affected. The two test cases modified in this patch is to check PPC's swap removal, not related to `store`s. So it's better to add `volatile` flag to them, for eliminating unintended test break.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D70373

Files:
  llvm/test/CodeGen/PowerPC/swaps-le-5.ll
  llvm/test/CodeGen/PowerPC/swaps-le-6.ll


Index: llvm/test/CodeGen/PowerPC/swaps-le-6.ll
===================================================================
--- llvm/test/CodeGen/PowerPC/swaps-le-6.ll
+++ llvm/test/CodeGen/PowerPC/swaps-le-6.ll
@@ -60,7 +60,7 @@
   %0 = load <2 x double>, <2 x double>* @x, align 16
   %1 = load double, double* @y, align 8
   %vecins = insertelement <2 x double> %0, double %1, i32 0
-  store <2 x double> %vecins, <2 x double>* @z, align 16
+  store volatile <2 x double> %vecins, <2 x double>* @z, align 16
   ret void
 }
 
@@ -105,7 +105,7 @@
   %0 = load <2 x double>, <2 x double>* @x, align 16
   %1 = load double, double* @y, align 8
   %vecins = insertelement <2 x double> %0, double %1, i32 1
-  store <2 x double> %vecins, <2 x double>* @z, align 16
+  store volatile <2 x double> %vecins, <2 x double>* @z, align 16
   ret void
 }
 
Index: llvm/test/CodeGen/PowerPC/swaps-le-5.ll
===================================================================
--- llvm/test/CodeGen/PowerPC/swaps-le-5.ll
+++ llvm/test/CodeGen/PowerPC/swaps-le-5.ll
@@ -10,7 +10,7 @@
 entry:
   %0 = load <2 x double>, <2 x double>* @x, align 16
   %vecins = insertelement <2 x double> %0, double %y, i32 0
-  store <2 x double> %vecins, <2 x double>* @z, align 16
+  store volatile <2 x double> %vecins, <2 x double>* @z, align 16
   ret void
 }
 
@@ -25,7 +25,7 @@
 entry:
   %0 = load <2 x double>, <2 x double>* @x, align 16
   %vecins = insertelement <2 x double> %0, double %y, i32 1
-  store <2 x double> %vecins, <2 x double>* @z, align 16
+  store volatile <2 x double> %vecins, <2 x double>* @z, align 16
   ret void
 }
 
@@ -41,7 +41,7 @@
   %0 = load <2 x double>, <2 x double>* @z, align 16
   %1 = load <2 x double>, <2 x double>* @x, align 16
   %vecins = shufflevector <2 x double> %0, <2 x double> %1, <2 x i32> <i32 0, i32 2>
-  store <2 x double> %vecins, <2 x double>* @z, align 16
+  store volatile <2 x double> %vecins, <2 x double>* @z, align 16
   ret void
 }
 
@@ -57,7 +57,7 @@
   %0 = load <2 x double>, <2 x double>* @z, align 16
   %1 = load <2 x double>, <2 x double>* @x, align 16
   %vecins = shufflevector <2 x double> %0, <2 x double> %1, <2 x i32> <i32 3, i32 1>
-  store <2 x double> %vecins, <2 x double>* @z, align 16
+  store volatile <2 x double> %vecins, <2 x double>* @z, align 16
   ret void
 }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D70373.229748.patch
Type: text/x-patch
Size: 2314 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191118/59d21ab9/attachment.bin>


More information about the llvm-commits mailing list