[PATCH] D70364: Fix iOSDarwin()'s doc comment to also include tvOS.

Varun Gandhi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 17 13:10:36 PST 2019


varungandhi-apple created this revision.
varungandhi-apple added a reviewer: rjmccall.
Herald added subscribers: llvm-commits, dexonsmith.
Herald added a project: LLVM.

I saw the doc comment using the Option + Click in Xcode and I was
confused by the fact that tvOS wasn't listed. The method definition
also doesn't make it clear that the check for tvOS is taking place as
the tvOS check is hidden in the isiOS() check.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D70364

Files:
  llvm/include/llvm/ADT/Triple.h


Index: llvm/include/llvm/ADT/Triple.h
===================================================================
--- llvm/include/llvm/ADT/Triple.h
+++ llvm/include/llvm/ADT/Triple.h
@@ -477,7 +477,7 @@
     return getSubArch() == Triple::ARMSubArch_v7k;
   }
 
-  /// isOSDarwin - Is this a "Darwin" OS (OS X, iOS, or watchOS).
+  /// isOSDarwin - Is this a "Darwin" OS (OS X, iOS, tvOS or watchOS).
   bool isOSDarwin() const {
     return isMacOSX() || isiOS() || isWatchOS();
   }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D70364.229727.patch
Type: text/x-patch
Size: 478 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191117/0cc13ec8/attachment.bin>


More information about the llvm-commits mailing list