[PATCH] D70271: [AIX][XCOFF] Write Function descriptors and TOC base to data section
Digger via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Nov 17 12:27:11 PST 2019
DiggerLin added inline comments.
================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:255
report_fatal_error("Unhandled mapping of read-write csect to section.");
+ case XCOFF::XMC_DS:
+ return DataCsects;
----------------
jasonliu wrote:
> jasonliu wrote:
> > DiggerLin wrote:
> > > DiggerLin wrote:
> > > > I am not sure whether all function description data will be group together and than put in the .data section of xcoffobjectfile? all the variable data and function description will be interleaved into data section.
> > > >
> > > > As I remember, I read some document , it talk about that , we put all variables in the data section first. then function description,s final is TOC entries. Maybe I wrong.
> > > >
> > > I prefer added CsectGroup DSCsects; for function description csect.
> > Interleaving is acceptable for XCOFF format. What it hurts is readability of the symbol table.
> > But I think the current implementation would naturally put all the global datas first and then function descriptor later, because we always emit global data first and then process each function.
> I can add a separate CsectGroup to make the contract more explicit.
thanks Jason for clarification.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70271/new/
https://reviews.llvm.org/D70271
More information about the llvm-commits
mailing list