[PATCH] D70350: [DWARF] Allow cross-CU references of subprogram definitions

[Vedant Kumar via Phabricator via llvm-commits]

vsk updated this revision to Diff 229676.
vsk added a comment.

@aprantl I think the patch is correct as-written, but not for the reasons I expected :). It would be incorrect to //not// share TU-local subprogram definitions, I think. That's because such a definition may be inlined into a different TU, in which case a call to it would still need to be described. I've added a test case to illustrate this. I've also updated the comment to clarify the new situation.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70350/new/

https://reviews.llvm.org/D70350

Files:
  llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp
  llvm/test/DebugInfo/X86/lto-cross-cu-call-origin-ref.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D70350.229676.patch
Type: text/x-patch
Size: 7749 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191116/b7e63bca/attachment-0001.bin>