[PATCH] D70243: Lowering CPI/JTI/BA to assembly

Xiangling Liao via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 17 07:36:16 PST 2019


Xiangling_L added a comment.

In D70243#1748063 <https://reviews.llvm.org/D70243#1748063>, @jasonliu wrote:

> When I apply your patch to master, it didn't apply cleanly. So please rebase.
>  And when I did some work to manually apply it, and run through clang-format, clang-format changed several places.
>  I suspect it's due to the tabs vs space issue. 
>  I suggest to update this patch with after running the clang-format on it.


Thanks for your advice, I rebased this PR and fixed the format issue. Please try again to see if you can apply it on latest master.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70243/new/

https://reviews.llvm.org/D70243





More information about the llvm-commits mailing list