[PATCH] D70352: [PowerPC] Rename DarwinDirective to CPUDirective (NFC)

Jinsong Ji via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 15 19:28:28 PST 2019


jsji accepted this revision as: jsji.
jsji added a comment.
This revision is now accepted and ready to land.

LGTM. Thanks for the clean up!
The only other instance containing `DarwinDirective` is `ParseDarwinDirectiveMachine` in `PPCAsmParser.cpp` , and it is for Mach-O parsing, so it is reasonable to do not rename it.



================
Comment at: llvm/lib/Target/PowerPC/PPCSubtarget.h:172
   /// getDarwinDirective - Returns the -m directive specified for the cpu.
+  unsigned getDarwinDirective() const { return CPUDirective; }
+
----------------
Shall we explicitly add doxygen `\deprecated` in comments? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70352/new/

https://reviews.llvm.org/D70352





More information about the llvm-commits mailing list