[PATCH] D69835: Add options for PPC to enable/disable using non-volatile CR

[qshanz via Phabricator via llvm-commits]

steven.zhang added a comment.

Well, this sounds like a tune option.I am fine with it. Just one concern on the implementation.



================
Comment at: llvm/lib/Target/PowerPC/PPCRegisterInfo.h:25
 class PPCTargetMachine;
+extern cl::opt<bool> DisableNonVolatileCR;
 
----------------
This is not a good idea as you are polluting the namespace. If you really want to share information between compilation unit, you can declare local variable in sub target, and initialize it to the debug opt some where.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69835/new/

https://reviews.llvm.org/D69835