[PATCH] D70263: [Error] Add source location macro

[Don Hinton via Phabricator via llvm-commits]

hintonda added a comment.

In D70263#1748105 <https://reviews.llvm.org/D70263#1748105>, @lhames wrote:

> I'm not sure I follow this. My understanding is that FileError was designed to make it easy to attach a source location to an error generated while operating on a file, but this patch is adapting it to track the LLVM source location that generated the error, right?


Yes.

> I don't think we want to do that -- it makes it very difficult to reason about what FileError's fields mean.

In my initial commit, I had added a new class specifically for this, SourceLocationError, but @beanz convinced me to reuse FileError, since the only difference was the message formatting.

Should I add back SourceLocationError?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70263/new/

https://reviews.llvm.org/D70263