[PATCH] D69497: [PowerPC] Fix MI peephole optimization for splats

Nemanja Ivanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 15 13:04:13 PST 2019


nemanjai added a comment.

In D69497#1730212 <https://reviews.llvm.org/D69497#1730212>, @vddvss wrote:

> Also, I noticed in the `case PPC::XXPERMDI:` block there are a couple of nested `if`s without `else`s and checks on `if`s that could simplified by converted to early `break`s, albeit at the cost of polluting `git blame` with whitespace differences. Let me know if you are interested in a separate patch to clean some of that up.


Any refactoring patch that makes the code flow better or makes it more readable is always welcome and appreciated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69497/new/

https://reviews.llvm.org/D69497





More information about the llvm-commits mailing list