[PATCH] D69443: [PowerPC] Test case for vector float gather on ppc64le and ppc64

Stefan Pintilie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 15 12:19:52 PST 2019


stefanp added a comment.

I think this patch is fine now.
I only have one minor comment.



================
Comment at: llvm/test/CodeGen/PowerPC/float-vector-gather.ll:2
+; NOTE: This test ensures that for both Big and Little Endian cases a set of
+; NOTE: 4 floats is gathered into a v4i32 register using xxmrghd, xvcvdpsp,
+; NOTE: and vmrgew.
----------------
nit:
I think you mean `v4f32` and not `v4i32` since they are all floats.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69443/new/

https://reviews.llvm.org/D69443





More information about the llvm-commits mailing list