[PATCH] D70334: [LegalizeDAG] Convert strict fp nodes to libcalls without losing the chain.

[Craig Topper via Phabricator via llvm-commits]

craig.topper created this revision.
craig.topper added reviewers: kpn, andrew.w.kaylor, uweigand, pengfei, LiuChen3.
Herald added a subscriber: hiraditya.
Herald added a project: LLVM.

Previously we mutated the node and then converted it to a libcall. But this loses the chain information.

This patch keeps the chain, but unfortunately breaks tail call optimization as the functions involved in deciding if a node is in tail call position can't handle the chain. But correct ordering seems more important to be right.

Somehow the SystemZ tests improved. I looked at one of them and it seemed that we're handling the split vector elements in a different order and that made the copies work better.


https://reviews.llvm.org/D70334

Files:
  llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp
  llvm/test/CodeGen/SystemZ/vector-constrained-fp-intrinsics.ll
  llvm/test/CodeGen/X86/fp-intrinsics-fma.ll
  llvm/test/CodeGen/X86/fp-intrinsics.ll
  llvm/test/CodeGen/X86/vector-constrained-fp-intrinsics.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D70334.229613.patch
Type: text/x-patch
Size: 77026 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191115/c2d597f8/attachment-0001.bin>