[PATCH] D70243: Lowering CPI/JTI/BA to assembly

[Jason Liu via Phabricator via llvm-commits]

jasonliu added a comment.

When I apply your patch to master, it didn't apply cleanly. So please rebase.
And when I did some work to manually apply it, and run through clang-format, clang-format changed several places.
I suspect it's due to the tabs vs space issue. 
I suggest to update this patch with after running the clang-format on it.



================
Comment at: llvm/include/llvm/CodeGen/TargetLoweringObjectFileImpl.h:237
+  MCSection *getSectionForJumpTable(const Function &F,
+		                    const TargetMachine &TM) const override;
+
----------------
Format looks off here. You might used tabs instead of space. 


================
Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:1758
+      if (TM.getTargetTriple().isOSBinFormatXCOFF()) {
+	cast<MCSymbolXCOFF>(Sym)->setContainingCsect(
+	    cast<MCSectionXCOFF>(CPSections[i].S));
----------------
Format issue:
This line doesn't look like aligned. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70243/new/

https://reviews.llvm.org/D70243