[PATCH] D69117: [gicombiner] Process the MatchDag such that every node is reachable from the roots

[Volkan Keles via Phabricator via llvm-commits]

volkan accepted this revision.
volkan added a comment.
This revision is now accepted and ready to land.

LGTM with a couple of nits.



================
Comment at: llvm/utils/TableGen/GICombinerEmitter.cpp:160
+    while (!EdgesRemaining.empty()) {
+      SmallSet<GIMatchDagEdge *, 20> EdgesToRemove;
+      for (auto EI = EdgesRemaining.begin(), EE = EdgesRemaining.end();
----------------
No need to create a new set for each edge, this can be moved outside of the loop.


================
Comment at: llvm/utils/TableGen/GICombinerEmitter.cpp:189
+      if (!Progressed) {
+        LLVM_DEBUG(dbgs() << "No progress\n");
+        return;
----------------
Looks like there is no other debug output in this functions, is it worth keeping this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69117/new/

https://reviews.llvm.org/D69117