[llvm] 67c416d - [DebugInfo] Allow spill slots in call site parameter descriptions

Fangrui Song via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 15 10:02:09 PST 2019


Author: Vedant Kumar
Date: 2019-11-15T09:55:36-08:00
New Revision: 67c416dc9a5aeda034d46bdcb3b63fffa462d28e

URL: https://github.com/llvm/llvm-project/commit/67c416dc9a5aeda034d46bdcb3b63fffa462d28e
DIFF: https://github.com/llvm/llvm-project/commit/67c416dc9a5aeda034d46bdcb3b63fffa462d28e.diff

LOG: [DebugInfo] Allow spill slots in call site parameter descriptions

Allow call site paramter descriptions to reference spill slots. Spill
slots are not visible to high-level LLVM IR, so they can safely be
referenced during entry value evaluation (as they cannot be clobbered by
some other function).

This gives a 5% increase in the number of call site parameter DIEs in an
LTO x86_64 build of the xnu kernel.

This reverts commit eb4c98ca3d2590bad9f6542afbf3a7824d2b53fa (
[DebugInfo] Exclude memory location values as parameter entry values),
effectively reintroducing the portion of D60716 which dealt with memory
locations (authored by Djordje, Nikola, Ananth, and Ivan).

This partially addresses llvm.org/PR43343. However, not all memory
operands forwarded to callees live in spill slots. In the xnu build, it
may be possible to use an escape analysis to increase the number of call
site parameter by another 15% (more details in PR43343).

Differential Revision: https://reviews.llvm.org/D70254

Added: 
    llvm/test/tools/yaml2obj/COFF/xrelocs.yaml

Modified: 
    

Removed: 
    llvm/test/tools/yaml2obj/coff-xrelocs.yaml


################################################################################
diff  --git a/llvm/test/tools/yaml2obj/coff-xrelocs.yaml b/llvm/test/tools/yaml2obj/COFF/xrelocs.yaml
similarity index 100%
rename from llvm/test/tools/yaml2obj/coff-xrelocs.yaml
rename to llvm/test/tools/yaml2obj/COFF/xrelocs.yaml


        


More information about the llvm-commits mailing list