[PATCH] D70208: [SimplifyCFG] propagate fast-math-flags (FMF) from phi to select

[Sanjay Patel via Phabricator via llvm-commits]

spatel marked an inline comment as done.
spatel added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/SimplifyCFG.cpp:1416
                                  BB1V->getName() + "." + BB2V->getName(), BI));
+      }
 
----------------
cameron.mcinally wrote:
> Have we considered adding a `CreateSelectFMF(...)`? It could be a little weird though, since CreateSelect(...) handles both Int and FP...
I hadn't thought of that, but that's a possibility. We could assert that if an optional FMF was passed to the builder as a parameter that the select actually is an FPMathOperator.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70208/new/

https://reviews.llvm.org/D70208