[PATCH] D70258: [OpenMP][IR-Builder] Introduce the finalization stack
Alexey Bataev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Nov 15 09:47:35 PST 2019
ABataev added inline comments.
================
Comment at: llvm/include/llvm/Frontend/OpenMPIRBuilder.h:69-71
+ void pushFinalizationCB(FinalizationInfo &&FI) {
+ FinalizationStack.emplace_back(std::move(FI));
+ }
----------------
jdoerfert wrote:
> ABataev wrote:
> > jdoerfert wrote:
> > > ABataev wrote:
> > > > Maybe `push...` for const reference and `emplace...` for variadic template (just like in standard library)?
> > > That would defeat the purpose of using move semantic. I can make it a push but we will then have to copy and not move.
> > You can use it in `emplace` version while `push...` function will rely on copy semantics.
> I only call this once, why do I need multiple versions?
I thought that we may need it later in other cases, no?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70258/new/
https://reviews.llvm.org/D70258
More information about the llvm-commits
mailing list