[PATCH] D70271: [AIX][XCOFF] Write Function descriptors and TOC base to data section

[Digger via Phabricator via llvm-commits]

DiggerLin added inline comments.


================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:255
     report_fatal_error("Unhandled mapping of read-write csect to section.");
+  case XCOFF::XMC_DS:
+      return DataCsects;
----------------
DiggerLin wrote:
> I am not sure whether all function description data will be group together and than put in the .data section of xcoffobjectfile?  all the variable data and function description will be interleaved into data section.
> 
> As I remember, I read some document , it talk about that , we put all variables in the data section first. then function description,s final is TOC entries.   Maybe I wrong.
> 
I prefer added CsectGroup DSCsects; for function description csect. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70271/new/

https://reviews.llvm.org/D70271