[PATCH] D69594: Warn when an output section name is longer than 8 characters

Fri Nov 15 05:16:48 PST 2019

mstorsjo added a comment.

In D69594#1726649 <https://reviews.llvm.org/D69594#1726649>, @mstorsjo wrote:

> > Microsoft's dumpbin tool cannot handle such PE files.
>
> This had me quite surprised, as I'm sure it was able to handle them just fine.
>
> By testing a few different versions of such tools I had lying around, I see that this worked just fine up to MSVC 2019 16.1, but in 16.2 it changed to error out with "LINK : fatal error LNK1328: missing string table". I'm a bit unsure about whether this really is intended behaviour, or just a bug.

FYI, I found a existing bug report for this exact issue, https://developercommunity.visualstudio.com/content/problem/777863/dumpbin-regression-in-since-toolset-1422.html, which is marked as fixed, pending release. So apparently the dumpbin misbehaviour is just a regression.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69594/new/

https://reviews.llvm.org/D69594