[PATCH] D70240: [ARM][ReachingDefs] Remove dead code in loloops.

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 15 04:56:47 PST 2019


SjoerdMeijer added inline comments.


================
Comment at: llvm/lib/CodeGen/ReachingDefAnalysis.cpp:234
+ 
+      if (getReachingMIDef(&*MI, PhysReg) != Def)
+        return;
----------------
Just a quick question on this. 
At this point, I think we have found an instruction that defines PhysReg, so I was looking into why we need to call getReachingMIDef , but perhaps you can help me, and/or place a comment if you think that is useful.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70240/new/

https://reviews.llvm.org/D70240





More information about the llvm-commits mailing list