[PATCH] D69847: DWARFDebugLoc(v4): Add an incremental parsing function

[Pavel Labath via Phabricator via llvm-commits]

labath marked 3 inline comments as done.
labath added a comment.

Thanks for the review. I'll incorporate the comments before committing.



================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugLoc.cpp:181
   DataExtractor::Cursor C(*Offset);
+  bool Continue = true;
+  while (Continue) {
----------------
JDevlieghere wrote:
> Any reason you prefer this over while(true) with a break? Just asking out of curiosity. 
I think I was influenced by the other loops in this patch which do some extra work after setting the "continue" flag. while(true) seems fine here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69847/new/

https://reviews.llvm.org/D69847