[PATCH] D70157: Align branches within 32-Byte boundary

[Kan Shengchen via Phabricator via llvm-commits]

skan marked 3 inline comments as done.
skan added inline comments.


================
Comment at: llvm/test/MC/X86/i386-align-branch-1a.s:1
+# RUN: llvm-mc -filetype=obj -triple i386-unknown-unknown --x86-align-branch-boundary=32 --x86-align-branch=fused-jcc-jmp  --x86-align-branch-prefix-size=5 %s | llvm-objdump -d  - | FileCheck %s
+# RUN: llvm-mc -filetype=obj -triple i386-unknown-unknown --x86-branches-within-32B-boundaries %s | llvm-objdump -d  - | FileCheck %s
----------------
MaskRay wrote:
> MaskRay wrote:
> > If you want to test that `--x86-branches-within-32B-boundaries` expands to the 3 other `--x86-*` options.
> > 
> > ```
> > ... -o %t
> > ... -o %t2
> > cmp %t %t2
> > FileCheck --input-file %t
> > ```
> We need a file-level comment describing the purpose of the test.
> 
> What do `1a`, `2a`, and `5a` mean? If we can find appropriate, descriptive names, use them. Don't simply copy the binutils tests. If tests exist for each of the used instruction prefix, write a comment to make that clear.
i will do it later


================
Comment at: llvm/test/MC/X86/i386-align-branch-1a.s:9
+# CHECK: 00000000 foo:
+# CHECK:        0: 65 65 65 a3 01 00 00 00      	movl	%eax, %gs:1
+# CHECK:        8: 55                           	pushl	%ebp
----------------
MaskRay wrote:
> MaskRay wrote:
> > Use `CHECK-NEXT:` (see https://llvm.org/docs/CommandGuide/FileCheck.html)
> > 
> > Add comments where REX prefixes or NOPs are used.
> Don't mix tabs with spaces. The columns do not align in an editor.
Done


================
Comment at: llvm/test/MC/X86/i386-align-branch-1a.s:9
+# CHECK: 00000000 foo:
+# CHECK:        0: 65 65 65 a3 01 00 00 00      	movl	%eax, %gs:1
+# CHECK:        8: 55                           	pushl	%ebp
----------------
skan wrote:
> MaskRay wrote:
> > MaskRay wrote:
> > > Use `CHECK-NEXT:` (see https://llvm.org/docs/CommandGuide/FileCheck.html)
> > > 
> > > Add comments where REX prefixes or NOPs are used.
> > Don't mix tabs with spaces. The columns do not align in an editor.
> Done
I will do it later


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70157/new/

https://reviews.llvm.org/D70157