[PATCH] D70237: [X86] Add more addcarry tests

David Zarzycki via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 15 05:26:40 PST 2019


davezarzycki added a comment.

When you update the tests, please remove the URLs. Also, what do you see they tests adding above and beyond what already exist in the file? For example, the nested structures design only changes the operands to getelementptr, but it doesn't change how the add/sub carry optimization works. And the by-reference versus by-value tests are also independent of the add/sub carry optimization.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70237/new/

https://reviews.llvm.org/D70237





More information about the llvm-commits mailing list