[PATCH] D70240: [ARM][ReachingDefs] Remove dead code in loloops.

[Dave Green via Phabricator via llvm-commits]

dmgreen added inline comments.


================
Comment at: llvm/lib/CodeGen/ReachingDefAnalysis.cpp:229
+  MachineBasicBlock::iterator MI = MachineBasicBlock::iterator(Def);
+  while (++MI != MBB->end()) {
+    for (auto &MO : MI->operands()) {
----------------
Does this detect other uses outside of the BB? If the value is live-out.


================
Comment at: llvm/lib/Target/ARM/ARMLowOverheadLoops.cpp:375
+    if (RDA->getReachingDef(VCTP, NumElements) >= 0)
+      CannotTailPredicate = true;
+    else {
----------------
Maybe make this into a lambda and do some early exits.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70240/new/

https://reviews.llvm.org/D70240