[PATCH] D70211: Sink all InitializePasses.h includes

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 14 09:38:40 PST 2019


rnk added a comment.

So, apparently this broke almost every buildbot because gtest binaries are not included in the `all` target, which I built on Linux and Windows before I pushed and then had to run off for the day. Thanks to @aheejin for fixing the build. In the future, please don't wait for review if the build is broken. A revert would've been appropriate and wouldn't need review, and a point fixes don't really need review. In any case, things seem to be stable this morning. Sorry for the disturbance!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70211/new/

https://reviews.llvm.org/D70211





More information about the llvm-commits mailing list