[PATCH] D70226: Add an option to disable strict float node mutating to an normal float node

[Pengfei Wang via Phabricator via llvm-commits]

pengfei added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:3715
 
-  if (Results.empty() && Node->isStrictFPOpcode()) {
+  if ((!DisableStrictNodeMutation && !TLI.isStrictFPEnabled())
+      && Results.empty() && Node->isStrictFPOpcode()) {
----------------
Is it better to use `!(TLI.isStrictFPEnabled() || DisableStrictNodeMutation)` ?


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp:1170
       // selectors.
-      if (Node->isStrictFPOpcode() &&
-          (TLI->getOperationAction(Node->getOpcode(), Node->getValueType(0))
+      if ((!DisableStrictNodeMutation && !TLI->isStrictFPEnabled())
+          && Node->isStrictFPOpcode()
----------------
Same as above.


================
Comment at: llvm/lib/Target/SystemZ/SystemZISelLowering.cpp:639
+  // Default to having -disable-strictnode-mutation on
+   IsStrictFPEnabled = true;
 }
----------------
Extra blank.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70226/new/

https://reviews.llvm.org/D70226