[PATCH] D70292: Make it possible to redirect not only errs() but also outs()

[Rui Ueyama via Phabricator via llvm-commits]

ruiu marked an inline comment as done.
ruiu added inline comments.


================
Comment at: lld/lib/Driver/DarwinLdDriver.cpp:1147
 bool link(llvm::ArrayRef<const char *> args, bool CanExitEarly,
-          raw_ostream &Error) {
+          raw_ostream &StdoutOS, raw_ostream &StderrOS) {
   errorHandler().logName = args::getFilenameWithoutExe(args[0]);
----------------
MaskRay wrote:
> I think we can just use `stdoutOS` and `stderrOS`, there is no need for consistency with local variable names. Note that `args` is also not capitalized...
Yeah, I can use the variables directly, but I found that `*stdoutOS << "something"` look a bit awkward, and you can remove `*` if you make them functions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70292/new/

https://reviews.llvm.org/D70292