[PATCH] D70234: AMDGPU: Change boolean content type to 0 or 1

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 14 23:46:28 PST 2019


arsenm added a comment.

In D70234#1746321 <https://reviews.llvm.org/D70234#1746321>, @rampitec wrote:

> What about patterns like these:
>
>    def : GCNPat <
>      (i1 (add i1:$src0, (i1 -1))),
>      (S_NOT_B64 $src0)
>   >;
>   
>    def : GCNPat <
>      (i1 (sub i1:$src0, (i1 -1))),
>      (S_NOT_B64 $src0)
>   >;
>   
>   
>
> will -1 still be generated or will we get 1's now and miss these patterns?


The target boolean content doesn't influence this context. There's no extension here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70234/new/

https://reviews.llvm.org/D70234





More information about the llvm-commits mailing list