[PATCH] D69982: PPC: Prepare tests for switch of default denormal-fp-math
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 14 18:35:27 PST 2019
arsenm added a comment.
In D69982#1746873 <https://reviews.llvm.org/D69982#1746873>, @steven.zhang wrote:
> Well, it seems that it is still too early to review this change. One comments: I see that, we have the code sequence change if switch to ieee. sqrt_afn_ieee is slower than sqrt_afn. As you are trying to set it as ieee for target that didn't explicit set the denormal-fp-math, which means that, this will affect PowerPC. Could we have the Frontend set the denormal-fp-math for PowerPC as non-ieee, so that, you don't need this patch any more ?
Based on the comments in bug 34994, the current behavior is broken on PowerPC. Denormals are enabled by default, so the sqrt expansion is broken. It would be incorrect to default to non-ieee
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69982/new/
https://reviews.llvm.org/D69982
More information about the llvm-commits
mailing list