[PATCH] D69578: [AIX] Add support for lowering int, float and double formal arguments.

Thu Nov 14 12:34:22 PST 2019

ZarkoCA marked 4 inline comments as done.
ZarkoCA added inline comments.

================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:6807
+
+SDValue PPCTargetLowering::truncateScalarIntegerArg(ISD::ArgFlagsTy Flags,
+                                                    EVT ValVT,
----------------
sfertile wrote:
> Does it need to be a member of `PPCTargetLowering`? It looks like we are passing in everything we use. If we can reduce its scope to a static in `PPCISelLowering.cpp` I would prefer that.
Agreed, I was only following the convention of extendArgforPPC64 but there is no reason for it to be a member. 

================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:6881
+            truncateScalarIntegerArg(Flags, ValVT, DAG, ArgValue, LocVT, dl);
+        ArgValue = DAG.getCopyFromReg(Chain, dl, VReg, LocVT);
+      }
----------------
sfertile wrote:
> Why the extra CopyFromReg?
My mistake, removed now. 

================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:6810
-  if (Subtarget.hasAltivec())
-    report_fatal_error("Altivec support is unimplemented on AIX.");

----------------
I removed the fatal error and changed back the tests that were failing. 

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69578/new/

https://reviews.llvm.org/D69578