[PATCH] D70182: Add read-only data assembly writing

[Digger via Phabricator via llvm-commits]

DiggerLin marked 2 inline comments as done.
DiggerLin added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1752
+       !GVKind.isReadOnly()) ||
+      (GVKind.isMergeableCString() || GVKind.isMergeableConst()))
     report_fatal_error("Encountered a global variable kind that is "
----------------
daltenty wrote:
> The extra parenthesis around this expression are unnecessary 
deleted the parenthesis of (GVKind.isMergeableCString() || GVKind.isMergeableConst()) ,  I prefer to keep the parenthesis of (!GVKind.isCommon() && !GVKind.isBSS() && !GVKind.isData() &&
       !GVKind.isReadOnly())  for readable reason. 


================
Comment at: llvm/test/CodeGen/PowerPC/aix-xcoff-rodata.ll:51
+; CHECK-NEXT:          .llong  4616189618054758400
+
----------------
Xiangling_L wrote:
> Please remove this extra blank line.
deleted ,thanks


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70182/new/

https://reviews.llvm.org/D70182