[PATCH] D70233: [WIP][NOT FOR COMMIT][Attributor] AAReachability Attribute

[Stefan Stipanovic via Phabricator via llvm-commits]

sstefan1 added a comment.

Nice to see other people working on this! :)



================
Comment at: llvm/include/llvm/Transforms/IPO/Attributor.h:1687
+struct AAReachability
+    : public IRAttribute<Attribute::Reachability, AbstractAttribute> {
+  AAReachability(const IRPosition &IRP) : IRAttribute(IRP) {}
----------------
jdoerfert wrote:
> You don't need this to be an IRAttribute, an AbstractAttribute is sufficient. You will need to store the IRPosition in the class explicitly though.
I guess then we don't even need to have an actual IR attribute (and all the boilerplate that comes with it).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70233/new/

https://reviews.llvm.org/D70233