[PATCH] D70030: [MachineBlockPlacement] Update UnscheduledPredecessors when tail duplicate delete a block.

[Guozhi Wei via Phabricator via llvm-commits]

Carrot added a comment.

The original code doesn't correctly handle the case that the duplicated BB comes from a chain contains multiple BBs. So your patch looks reasonable to me. Could you enhance your comment to emphasize this case. It's better to make the comments of following loop more clearer. The current comments looks similar and confusing.

Considering duplicate a BB from a chain with multiple BBs, there is another bug in lambda RemovalCallback. If the duplicated BB is removed from a worklist, the following BB in same chain should be added to the worklist.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70030/new/

https://reviews.llvm.org/D70030