[PATCH] D70243: Lowering CPI/JTI/BA to assembly

[Sean Fertile via Phabricator via llvm-commits]

sfertile added inline comments.
Herald added a subscriber: wuzish.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:1757
 
+      if (getSubtargetInfo().getTargetTriple().getObjectFormat() ==
+	  Triple::XCOFF) {
----------------
Nit: Formatting.


================
Comment at: llvm/lib/CodeGen/MachineModuleInfo.cpp:123
+      Triple::XCOFF) {
+    MCSymbol *FnEntryPointSym =
+        Context.getOrCreateSymbol("." + Entry.Fn->getName());
----------------
IIUC we expect that the functions entry point symbol already exists, and has its containing csect properly set. If so it be more appropriate to use `Context.lookupSymbol` and have appropriate error handling if the symbol doesn't exist or if its containing csect is not set.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70243/new/

https://reviews.llvm.org/D70243