[PATCH] D70202: [mips] Enable `la` pseudo instruction on 64-bit arch

Thu Nov 14 07:30:48 PST 2019

Petar.Avramovic accepted this revision.
Petar.Avramovic added a comment.
This revision is now accepted and ready to land.

LGTM.

Since n32 worked before, you could change

> It accepts la pseudo instruction on 64-bit arch and just shows a warning.

It accepts la pseudo instruction on arch with  64-bit pointers and just shows a warning.

================
Comment at: llvm/test/MC/Mips/macro-la-64bit.s:1-6
+# RUN: llvm-mc %s -triple=mips-unknown-linux -show-encoding -mcpu=mips32r2 \
+# RUN:   | FileCheck %s
+# RUN: llvm-mc %s -triple=mips-unknown-linux -show-encoding -mcpu=mips32r6 \
+# RUN:   | FileCheck %s
+
+.set mips64r2
----------------
Judging by the test name, this test should check "la 64-bit-address".
Test has 32bit pointers because abi is O32, thus `Is32BitAddress` is true.
`.set mips64r2` did change the feature bits but abi remains as specified in `-triple=mips-unknown-linux`.
Additionally it would be nice to add a few instructions with i64 immediates like in macro-dla.s. 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70202/new/

https://reviews.llvm.org/D70202