[PATCH] D70105: [lit] Better/earlier errors for empty runs

[Joel E. Denny via Phabricator via llvm-commits]

jdenny added a comment.

In D70105#1745634 <https://reviews.llvm.org/D70105#1745634>, @probinson wrote:

> In D70105#1745051 <https://reviews.llvm.org/D70105#1745051>, @jdenny wrote:
>
> > I think it's using `utils\lit\tests\lit.site.cfg`, which produces the error, when it would normally use `utils/lit/tests/Inputs/nonexistent/lit.cfg`.  Creating even an empty version of that file would probably fix this.
>
>
> Hmmm then the directory wouldn't be nonexistent...


Good point.  Especially now that we know it can make a difference, it's probably worthwhile keeping that part.  I wonder if we should additionally check the case of an empty existing directory, which would also fail as originally intended here.

> I added an extra directory level in D70239 <https://reviews.llvm.org/D70239>, see what you think.

I'm following up further there.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70105/new/

https://reviews.llvm.org/D70105