[PATCH] D11833: s/NDEBUG/LLVM_NDEBUG/ in most places

Duncan P. N. Exon Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 13 13:56:28 PST 2019


dexonsmith added a comment.

In D11833#1744718 <https://reviews.llvm.org/D11833#1744718>, @mehdi_amini wrote:

> OK but these NDEBUG aren't necessarily harmful, are they?
>
> IIRC we added LLVM_ENABLE_ABI_BREAKING_CHECKS to cover the cases because previous using NDEBUG in the client was *required* to match the settings at the time LLVM was built.


Agree with Mehdi, we should only be using `LLVM_ENABLE_ABI_BREAKING_CHECKS` when it's actually an ABI-breaking check.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D11833/new/

https://reviews.llvm.org/D11833





More information about the llvm-commits mailing list