[PATCH] D54439: CMake: Make most target symbols hidden by default

Wed Nov 13 10:11:41 PST 2019

tstellar added a comment.

In D54439#1740802 <https://reviews.llvm.org/D54439#1740802>, @ldionne wrote:

> In D54439#1740734 <https://reviews.llvm.org/D54439#1740734>, @ldionne wrote:
>
> > In D54439#1722049 <https://reviews.llvm.org/D54439#1722049>, @tstellar wrote:
> >
> > > Rebase on trunk.
> > >
> > > The warnings are still present on OS X.  Here is a build log:
> > >  https://github.com/tstellar/llvm-project/pull/11/checks?check_run_id=275366813
> >
> >
> > @tstellar Can you add `_LIBCPP_INLINE_VISIBILITY` to `__call_once_proxy` and see whether that fixes the warning? I believe that is the correct fix, now that we don't use `always_inline` anymore to implement `_LIBCPP_INLINE_VISIBILITY`.
> >
> > I've added `_LIBCPP_INLINE_VISIBILITY` to `__call_once_proxy` locally and everything works, but I don't have your specific patch to test locally.
>
>
> Note that I've applied that change in 48b7068beca9 <https://reviews.llvm.org/rG48b7068beca9d3a39dcfbebcb384b59b7898065f> regardless because I think it's good, but I'm still curious to know whether it'll fix your problems.

I've confirmed that this change does fix the warning.  How do we we want to proceed with this patch?  The warnings will still be present on existing Mac OS installs.  Should we disable this change on Mac OS for now or should we keep it and live with the warnings?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54439/new/

https://reviews.llvm.org/D54439