[PATCH] D70234: AMDGPU: Change boolean content type to 0 or 1

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 14 04:15:39 PST 2019


arsenm created this revision.
arsenm added a reviewer: rampitec.
Herald added subscribers: hiraditya, t-tye, tpr, dstuttard, yaxunl, nhaehnle, wdng, jvesely, kzhuravl.
Herald added a project: LLVM.

The usage of target boolean checks is overly inflexible, since sext
and zext of a compare are equally cheap. The choice is arbitrary, but
using 0/1 to some degree is the choice of lower resistance since
that's what most targets use. This enables a few combines that don't
bother to support ZeroOrNegativeOneBooleanContent.


https://reviews.llvm.org/D70234

Files:
  llvm/lib/Target/AMDGPU/AMDGPUISelLowering.cpp
  llvm/lib/Target/AMDGPU/R600ISelLowering.cpp
  llvm/lib/Target/AMDGPU/SIISelLowering.cpp
  llvm/lib/Target/AMDGPU/SIInstrInfo.cpp
  llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.if.break.i32.ll
  llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.if.break.i64.ll
  llvm/test/CodeGen/AMDGPU/amdgcn.private-memory.ll
  llvm/test/CodeGen/AMDGPU/combine-cond-add-sub.ll
  llvm/test/CodeGen/AMDGPU/extract_vector_dynelt.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D70234.229275.patch
Type: text/x-patch
Size: 8597 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191114/b4e6c46a/attachment.bin>


More information about the llvm-commits mailing list