[PATCH] D69836: [MIR] Target specific MIR formating and parsing

Wed Nov 13 23:38:08 PST 2019

pguo marked 2 inline comments as done.
pguo added inline comments.

================
Comment at: llvm/lib/CodeGen/MachineOperand.cpp:1172
+      Formatter->printCustomPseudoSourceValue(OS, MST, *PVal);
+      OS << "\"";
       break;
----------------
dsanders wrote:
> pguo wrote:
> > arsenm wrote:
> > > Single quotes
> > Do you mean back quote here?  I intentionally use double quotes here for custom pseudo source value, since back quote `...` is used for quoted IR value, which could be part of the serialization output.  The design is custom pseudo source value is wrapped in double quoted string which will be passed to target specific formatter.  Inside the string it can have back quoted IR value as well as other customized text.
> I believe Matt means that it's a single character string so he's asking for `'\"'`
Thank you Daniel for clarification. 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69836/new/

https://reviews.llvm.org/D69836