[PATCH] D70105: [lit] Better/earlier errors for empty runs

[Paul Robinson via Phabricator via llvm-commits]

probinson added a comment.

This patch fails on Windows when built using the Visual Studio 2017 builder.  The new RUN lines in selecting.py for the "nonexistent" case will produce a diagnostic complaining about a missing 'build_mode' substitution:

  $ ":" "RUN: at line 7"
  $ "not" "env" "-u" "FILECHECK_OPTS" "-u" "FILECHECK_DUMP_INPUT_ON_FAILURE" "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python36_64\python.exe" "D:/Data/upstream/llvm-project/llvm\utils\lit\lit.py" "D:/Data/upstream/mbuild/utils/lit/tests\Inputs/nonexistent"
  $ "FileCheck" "--check-prefix=CHECK-BAD-PATH" "D:\Data\upstream\mbuild\utils\lit\tests\selecting.py"
  # command stderr:
  D:\Data\upstream\mbuild\utils\lit\tests\selecting.py:9:19: error: CHECK-BAD-PATH: expected string not found in input
  # CHECK-BAD-PATH: Did not disover any tests for provided path(s).
                    ^
  <stdin>:1:1: note: scanning from here
  lit.py: D:\Data\upstream\mbuild\utils\lit\tests\lit.site.cfg:18: fatal: unable to find 'build_mode' parameter, use '--param=build_mode=VALUE'
  ^
  <stdin>:1:62: note: possible intended match here
  lit.py: D:\Data\upstream\mbuild\utils\lit\tests\lit.site.cfg:18: fatal: unable to find 'build_mode' parameter, use '--param=build_mode=VALUE'
                                                               ^
  
  error: command failed with exit status: 1

This has to have something to do with Visual Studio being a multi-config builder (you specify Debug/Release/etc at build time, not CMake time) as opposed to ninja's single-config operation.  I'm afraid I'm not much help beyond that, though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70105/new/

https://reviews.llvm.org/D70105