[PATCH] D70192: [LoopCacheAnalysis]: Fix assertion failure during cost computation

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

Before I saw that the cost has to be a constant I wrote this:

  I'm unsure if a sign extend would not be more appropriate for the stride (for the trip count it doesn't matter I guess), but at the end of the day this is "just" a heuristic.
  Feel free to update it to sign extend if you feel that it is appropriate. Maybe try out with a negative stride test if you can see a difference.

Given that it has to be a constant it does not matter. If that might change, consider my comment above.

Otherwise, LGTM.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70192/new/

https://reviews.llvm.org/D70192