[PATCH] D70205: [llvm-objcopy][COFF] Add support for extended relocation tables

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

The code looks good to me, but it would be good to have a testcase that actually covers the writing part of the patch. As far as I see, the testcase only checks that we don't error out if the extended relocations flag is set on input, but as the test object doesn't actually have that many relocations, it doesn't invoke that bit of the writer.

One can use gzipped object files (see COFF/bigobj.test for an example) for testcases where one needs a slightly larger test file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70205/new/

https://reviews.llvm.org/D70205