[PATCH] D69870: [builtins] Implement rounding mode support for i386/x86_64

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 13 12:47:10 PST 2019


nickdesaulniers added inline comments.


================
Comment at: compiler-rt/lib/builtins/i386/fp_mode.c:37
+#endif
+} fenv_t;
+
----------------
It seems that `fenv_t` would be defined in `<cfenv>`, can you include that instead of redefining it?
http://www.cplusplus.com/reference/cfenv/fenv_t/

Looks like all of the above constants are defined as enums there, too.


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69870/new/

https://reviews.llvm.org/D69870





More information about the llvm-commits mailing list