[llvm] 597b77f - Add -disable-builtin option to opt

[Dimitry Andric via llvm-commits]

Author: Dimitry Andric
Date: 2019-11-13T21:32:49+01:00
New Revision: 597b77fb7ff9419c502a0bfa582688d1e70d0309

URL: https://github.com/llvm/llvm-project/commit/597b77fb7ff9419c502a0bfa582688d1e70d0309
DIFF: https://github.com/llvm/llvm-project/commit/597b77fb7ff9419c502a0bfa582688d1e70d0309.diff

LOG: Add -disable-builtin option to opt

Summary:
The option allows to disable specific target library builtin functions,
instead of -disable-simplify-libcalls, which disables all of them.

This is a prerequisite for D70143, which fixes PR43081.

Reviewers: xbolva00, spatel, jdoerfert, efriedma

Reviewed By: efriedma

Subscribers: llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D70193

Added: 
    llvm/test/Transforms/InstCombine/disable-builtin.ll

Modified: 
    llvm/tools/opt/opt.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/test/Transforms/InstCombine/disable-builtin.ll b/llvm/test/Transforms/InstCombine/disable-builtin.ll
new file mode 100644
index 000000000000..a301b914b860
--- /dev/null
+++ b/llvm/test/Transforms/InstCombine/disable-builtin.ll
@@ -0,0 +1,21 @@
+; Test that -disable-builtin works correctly.
+;
+; RUN: opt < %s -instcombine -disable-builtin strcat -S | FileCheck %s
+;
+; RUN: not opt < %s -instcombine -disable-builtin foobar -S 2>&1 | FileCheck --check-prefix=FOOBAR %s
+; FOOBAR: cannot disable nonexistent builtin function foobar
+
+target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128-n8:16:32:64-S128"
+
+ at empty = constant [1 x i8] c"\00", align 1
+
+declare i8* @strcat(i8*, i8*)
+
+define i8* @test_strcat(i8* %x) {
+; CHECK-LABEL: @test_strcat(
+  %empty = getelementptr [1 x i8], [1 x i8]* @empty, i32 0, i32 0
+  %ret = call i8* @strcat(i8* %x, i8* %empty)
+  ret i8* %ret
+; CHECK: call i8* @strcat
+}
+

diff  --git a/llvm/tools/opt/opt.cpp b/llvm/tools/opt/opt.cpp
index 1ad6079f67ba..092932237fd6 100644
--- a/llvm/tools/opt/opt.cpp
+++ b/llvm/tools/opt/opt.cpp
@@ -193,6 +193,12 @@ static cl::opt<bool>
 DisableSimplifyLibCalls("disable-simplify-libcalls",
                         cl::desc("Disable simplify-libcalls"));
 
+static cl::list<std::string>
+DisableBuiltins("disable-builtin",
+                cl::desc("Disable specific target library builtin function"),
+                cl::ZeroOrMore);
+
+
 static cl::opt<bool>
 Quiet("q", cl::desc("Obsolete option"), cl::Hidden);
 
@@ -726,6 +732,19 @@ int main(int argc, char **argv) {
   // The -disable-simplify-libcalls flag actually disables all builtin optzns.
   if (DisableSimplifyLibCalls)
     TLII.disableAllFunctions();
+  else {
+    // Disable individual builtin functions in TargetLibraryInfo.
+    LibFunc F;
+    for (auto &FuncName : DisableBuiltins)
+      if (TLII.getLibFunc(FuncName, F))
+        TLII.setUnavailable(F);
+      else {
+        errs() << argv[0] << ": cannot disable nonexistent builtin function "
+               << FuncName << '\n';
+        return 1;
+      }
+  }
+
   Passes.add(new TargetLibraryInfoWrapperPass(TLII));
 
   // Add internal analysis passes from the target machine.