[PATCH] D69639: Add support for lowering 32-bit/64-bit pointers

[Amy Huang via Phabricator via llvm-commits]

akhuang marked an inline comment as done.
akhuang added inline comments.


================
Comment at: llvm/lib/Target/X86/X86.h:156
+namespace X86AS {
+enum : unsigned {
+  GS = 256,
----------------
RKSimon wrote:
> use regular X86 namespace and name the enum?
> ```
> namespace X86 {
> enum class AddressSpace : unsigned {
> ```
I tried using an enum class but since address spaces are ints it is a bit inconvenient to convert them to enum types. is it better to not have different namespaces?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69639/new/

https://reviews.llvm.org/D69639