[PATCH] D70184: [MIPS GlobalISel] Select addiu

Simon Atanasyan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 13 10:55:24 PST 2019


atanasyan accepted this revision.
atanasyan added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Target/Mips/MipsInstrInfo.td:1268
 
 // Node immediate fits as 16-bit sign extended on target immediate.
 // e.g. addi, andi
----------------
It's unrelated to this patch but probably this comment should say about "8-bit sign extended".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70184/new/

https://reviews.llvm.org/D70184





More information about the llvm-commits mailing list