[PATCH] D69847: DWARFDebugLoc(v4): Add an incremental parsing function

Wed Nov 13 08:27:41 PST 2019

labath requested review of this revision.
labath marked an inline comment as done.
labath added a comment.

requesting re-review, as the this patch has changed/expanded substantially

================
Comment at: llvm/test/tools/dsymutil/X86/basic-lto-linking-x86.test:140-141
 CHECK:      0x00000025:
-CHECK-NEXT:              [0x0000000000000000, 0x000000000000000f): DW_OP_reg5 RDI, DW_OP_piece 0x4
-CHECK-NEXT:              [0x0000000000000019, 0x000000000000001d): DW_OP_reg5 RDI, DW_OP_piece 0x4
+CHECK-NEXT:              (0x0000000000000000, 0x000000000000000f): DW_OP_reg5 RDI, DW_OP_piece 0x4
+CHECK-NEXT:              (0x0000000000000019, 0x000000000000001d): DW_OP_reg5 RDI, DW_OP_piece 0x4

----------------
One thing I'm not sure of it's the syntax of these "raw" entries. The `()` syntax is sort of similar to the `DW_LLE(x,y)` syntax, but at same time, it's easy to miss that one is looking at the "raw" dump as the difference is only one character. OTOH, the v4 loclists don't have any fancy encodings, so the "raw" format is nearly the same as the "interpreted" format anyway...

Maybe we could use curly brackets here or something?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69847/new/

https://reviews.llvm.org/D69847