[PATCH] D70148: [SLP] fix miscompile on min/max reductions with extra uses (PR43948)

[Sanjay Patel via Phabricator via llvm-commits]

spatel marked an inline comment as done.
spatel added inline comments.


================
Comment at: llvm/test/Transforms/SLPVectorizer/X86/reduction.ll:118-119
   %rdx4 = select i1 %c0123, i32 %t8, i32 %t3
   %EXTRA_USE = icmp sgt i32 %rdx4, %t4
   %t14 = select i1 %EXTRA_USE, i32 %rdx4, i32 %t4
   %c012345 = icmp sgt i32 %t14, %t5
----------------
For reference (and I should improve the variable names or test comments): %t14 is the final step of what we recognize as the min/max reduction, and %EXTRA_USE is the compare part of that min/max op.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70148/new/

https://reviews.llvm.org/D70148