[PATCH] D70009: [ARM][ReachingDefAnalysis] Use RDA for loloops

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/ReachingDefAnalysis.cpp:138
   MF = &mf;
+  MF->getProperties().set(MachineFunctionProperties::Property::TracksLiveness);
   TRI = MF->getSubtarget().getRegisterInfo();
----------------
samparker wrote:
> dmgreen wrote:
> > Can you explain this? Is it valid to just set this property?
> This pass doesn't change the code so this should be fine. But now I'm thinking that this pass also should require that liveness information is correct on entry.
Yes, this should be setting this in getRequiredProperties


================
Comment at: llvm/lib/Target/ARM/ARMInstrThumb2.td:5235
 
+let Defs = [CPSR] in
 def t2LoopDec :
----------------
This is a separate change


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70009/new/

https://reviews.llvm.org/D70009