[PATCH] D70016: [InstCombine] Don't use getFirstNonPHI in FoldIntegerTypedPHI
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 13 02:52:30 PST 2019
fhahn added inline comments.
================
Comment at: llvm/lib/Transforms/InstCombine/InstCombinePHI.cpp:183
unsigned NumPhis = 0;
- for (auto II = BB->begin(), EI = BasicBlock::iterator(BB->getFirstNonPHI());
- II != EI; II++, NumPhis++) {
+ for (auto II = BB->begin(); II != BB->end(); II++, NumPhis++) {
// FIXME: consider handling this in AggressiveInstCombine
----------------
Could you just use the iterator range `BB->phis()`? This should automatically iterate until it hits a non-phi instruction.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70016/new/
https://reviews.llvm.org/D70016
More information about the llvm-commits
mailing list